Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProjectorId as value object #454

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Add ProjectorId as value object #454

merged 6 commits into from
Jan 5, 2024

Conversation

DanielBadura
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 126.386ms (±0.00%) | 126.023ms (±0.00%) | 32.594mb        | 32.594mb   |
| benchSave1Event ()                     | 968.300μs (±0.00%) | 1.580ms (±0.00%)   | 32.594mb        | 32.594mb   |
| benchSave10000Events ()                | 285.883ms (±0.00%) | 287.235ms (±0.00%) | 32.818mb        | 32.818mb   |
| benchSave10000Aggregates ()            | 12.238s (±0.00%)   | 13.088s (±0.00%)   | 32.594mb        | 32.594mb   |
| benchSave10000AggregatesTransaction () | 747.319ms (±0.00%) | 751.513ms (±0.00%) | 32.594mb        | 32.594mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.314ms (±0.00%)   | 2.301ms (±0.00%)   | 35.978mb        | 35.978mb   |
| benchSave10000Events () | 354.912ms (±0.00%) | 355.132ms (±0.00%) | 36.243mb        | 36.243mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.653ms (±0.00%)   | 2.004ms (±0.00%)   | 8.090mb         | 8.079mb    |
| benchSave10000Events () | 449.659ms (±0.00%) | 454.861ms (±0.00%) | 33.421mb        | 33.415mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 125.922ms (±0.00%) | 124.398ms (±0.00%) | 32.615mb        | 32.615mb   |
| benchLoad10000Events ()                | 197.800μs (±0.00%) | 197.100μs (±0.00%) | 32.615mb        | 32.615mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura marked this pull request as ready for review January 5, 2024 12:48
@DavidBadura DavidBadura merged commit da42f8c into 3.0.x Jan 5, 2024
31 of 33 checks passed
@DavidBadura DavidBadura deleted the projector-id branch January 5, 2024 12:49
@DanielBadura DanielBadura added this to the 3.0.0 milestone Jan 5, 2024
@DanielBadura DanielBadura added the enhancement New feature or request label Jan 5, 2024
@DavidBadura DavidBadura changed the title Add ProjectorId as VO Add ProjectorId as value object Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBadura DavidBadura DavidBadura approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielBadura @DavidBadura